Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smorin4/edit multiple #4583

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

Conversation

smorin4
Copy link
Contributor

@smorin4 smorin4 commented Jul 29, 2022

Body of work done to prototype multiple selection within the edit project menu. All changes were made inside the SharedFunctionality.UI project, the majority being in the VisualStudio/NewProject and VisualStudio/NewItem folders. Each of these folders contains its own MainViewModel.cs, which uses other view models for user input handling. With regard to these other view models, NewProject uses UserSelectionViewModel while NewItem uses TemplateSelectionViewModel.

In these changes, the TemplateSelectionViewModel was made to mimic the functionality of the UserSelectionViewModel, more specifically through the replacement of Groups (an ObservableCollection of TemplateGroupViewModels made to handle just one template input) with userSelectionGroups (an ObservableCollection of UserSelectionGroups made to handle multiple template inputs).

Additionally, the prototyped edit project menu includes all accurate UI ("+" symbols, counters for number of pages selected) except for the right pane, which includes the ability to remove selections and see them as they are added.

With this work, it is clear that a better starting point would be to add all entry points ('NewItem (Template Studio)' -> New Page, New Feature, etc.) into one, with the edit project wizard including a section for each. This would be very similar to the new project wizard and can thus be achieved by building on top of it instead of trying to forcibly add this functionality to the edit project wizard.

Issue: #4554

Applies to the following platforms:

  • WinUI
  • WPF
  • UWP

Sophia Morin and others added 30 commits May 20, 2022 14:49
@smorin4 smorin4 requested a review from mikebattista July 29, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants