-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smorin4/edit multiple #4583
Open
smorin4
wants to merge
58
commits into
microsoft:main
Choose a base branch
from
smorin4:smorin4/EditMultiple
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Smorin4/edit multiple #4583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
context issue
…age, but when clicked after using other pages its works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Body of work done to prototype multiple selection within the edit project menu. All changes were made inside the
SharedFunctionality.UI
project, the majority being in theVisualStudio/NewProject
andVisualStudio/NewItem
folders. Each of these folders contains its ownMainViewModel.cs
, which uses other view models for user input handling. With regard to these other view models,NewProject
usesUserSelectionViewModel
whileNewItem
usesTemplateSelectionViewModel
.In these changes, the
TemplateSelectionViewModel
was made to mimic the functionality of theUserSelectionViewModel
, more specifically through the replacement ofGroups
(an ObservableCollection ofTemplateGroupViewModels
made to handle just one template input) withuserSelectionGroups
(an ObservableCollection ofUserSelectionGroups
made to handle multiple template inputs).Additionally, the prototyped edit project menu includes all accurate UI ("+" symbols, counters for number of pages selected) except for the right pane, which includes the ability to remove selections and see them as they are added.
With this work, it is clear that a better starting point would be to add all entry points ('NewItem (Template Studio)' ->
New Page
,New Feature
, etc.) into one, with the edit project wizard including a section for each. This would be very similar to the new project wizard and can thus be achieved by building on top of it instead of trying to forcibly add this functionality to the edit project wizard.Issue: #4554
Applies to the following platforms: